[frameworks-kcmutils] [Bug 389585] Visual Bug: Bad Window Size For WIFI KCM

[Jan Grulich]

https://bugs.kde.org/show_bug.cgi?id=389585

Jan Grulich <***@redhat.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@redhat.com
Component|kcm |general
Assignee|***@redhat.com |kdelibs-***@kde.org
Product|plasma-nm |frameworks-kcmutils

--- Comment #5 from Jan Grulich <***@redhat.com> ---
This bug is actually not plasma-nm specific, other KCMs are small as well, when
opened. I spent some time trying to fix it from our side, but failed, managed
to do so only in kcmshell itself (if I remember correctly), I just didn't
consider it as a proper fix so didn't push for review.

[Andres Betts]

https://bugs.kde.org/show_bug.cgi?id=389585

--- Comment #6 from Andres Betts <***@gmail.com> ---
Thank you Jan. We will likely tackle this soon as we continue working on the
KCMs.

[Dr. Chapatin]

https://bugs.kde.org/show_bug.cgi?id=389585

Dr. Chapatin <***@gmx.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@bogdan.co

--- Comment #7 from Dr. Chapatin <***@gmx.com> ---
*** Bug 395422 has been marked as a duplicate of this bug. ***

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389585

Nate Graham <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@kde.org

--- Comment #8 from Nate Graham <***@kde.org> ---
*** Bug 395602 has been marked as a duplicate of this bug. ***

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389585

Nate Graham <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |CONFIRMED
Ever confirmed|0 |1

--- Comment #9 from Nate Graham <***@kde.org> ---
I think you just need to update the sizeHint, no?

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389585

Nate Graham <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@yahoo.com

--- Comment #10 from Nate Graham <***@kde.org> ---
*** Bug 393891 has been marked as a duplicate of this bug. ***

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389585

Nate Graham <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com

--- Comment #11 from Nate Graham <***@kde.org> ---
*** Bug 392673 has been marked as a duplicate of this bug. ***

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389585

Nate Graham <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com
CC| |***@gmail.com

--- Comment #11 from Nate Graham <***@kde.org> ---
*** Bug 392673 has been marked as a duplicate of this bug. ***

--- Comment #12 from Nate Graham <***@kde.org> ---
*** Bug 391564 has been marked as a duplicate of this bug. ***

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389585

Nate Graham <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Severity|minor |normal

--- Comment #13 from Nate Graham <***@kde.org> ---
Jan, could you maybe submit your patch anyway just to solicit feedback? This is
a pretty high-profile issue and especially since it affects other KCMs too, it
would be nice to get it resolved!

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389585

Nate Graham <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.kde.org/show_b
| |ug.cgi?id=396837

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=389585

Christoph Feck <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.kde.org/show_b
| |ug.cgi?id=396188

[b***@kde.org]

https://bugs.kde.org/show_bug.cgi?id=389585

***@yandex.com changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@yandex.com

--- Comment #14 from ***@yandex.com ---
*** Bug 397157 has been marked as a duplicate of this bug. ***

[Dr. Chapatin]

https://bugs.kde.org/show_bug.cgi?id=389585

--- Comment #15 from Dr. Chapatin <***@gmx.com> ---
bug 396076 seems related/duplicate.

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389585

Nate Graham <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com

--- Comment #16 from Nate Graham <***@kde.org> ---
*** Bug 396076 has been marked as a duplicate of this bug. ***

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=389585

Christoph Feck <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@hmrt.nl

--- Comment #17 from Christoph Feck <***@kde.org> ---
*** Bug 379858 has been marked as a duplicate of this bug. ***

[Dr. Chapatin]

https://bugs.kde.org/show_bug.cgi?id=389585

--- Comment #18 from Dr. Chapatin <***@gmx.com> ---
*** Bug 395454 has been marked as a duplicate of this bug. ***

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389585

Nate Graham <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|Visual Bug: Bad Window Size |Window is too small when
|For WIFI KCM |KCMs are opened standalone
| |(e.g. using `kcmshell5)

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389585

Nate Graham <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|Window is too small when |Window is too small when
|KCMs are opened standalone |KCMs are opened standalone
|(e.g. using `kcmshell5) |(e.g. using `kcmshell5),
| |and contents get cut off

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389585

Nate Graham <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com

--- Comment #19 from Nate Graham <***@kde.org> ---
*** Bug 394747 has been marked as a duplicate of this bug. ***

[Valeriy Malov]

https://bugs.kde.org/show_bug.cgi?id=389585

Valeriy Malov <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com

--- Comment #20 from Valeriy Malov <***@gmail.com> ---
There seem to be multiple problems

First, there seems to be a problem with QDialog + QScrollArea having some kind
of implicit preferred maximum size, after which dialog stops growing to fit
content. For example, all kcmshell5 dialogs open at 637x518 max for me no
matter what's the size of the widget inside.

Second, some widgets that have QML contents report incorrect size hint because
QML content takes time to initialize. This is why KScreen KCM has size hint
explicitly set, and it stops it from opening as extremely tiny window, but
issue 1 stops it from opening as a large enough window to fit all contents.

Third, few widgets already seem to have scrollable content (e.g. opengl kcm)
and they probably just need manual minimum size set.

First problem is the biggest issue I suppose, since it affects all KCMs with
large content and network manager KCM in particular, but I don't know where
this preferred size comes from so I don't know how to fix it yet :/

[Valeriy Malov]

https://bugs.kde.org/show_bug.cgi?id=389585

--- Comment #21 from Valeriy Malov <***@gmail.com> ---
Proposed fix for first issue: https://phabricator.kde.org/D14692

Second and third need to be hunt down per-KCM I suppose

[Valeriy Malov]

https://bugs.kde.org/show_bug.cgi?id=389585

Valeriy Malov <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/kcm
| |utils/23ba2b37ef825f0efccc1
| |69455f45b0dcdac97cf

--- Comment #22 from Valeriy Malov <***@gmail.com> ---
Git commit 23ba2b37ef825f0efccc169455f45b0dcdac97cf by Valeriy Malov.
Committed on 13/08/2018 at 08:55.
Pushed by valeriymalov into branch 'master'.

Use custom QScrollArea with size hint not limited by font size

Summary:
For some reason original QScrollArea has constraint on a size hint
This causes large KCMShell pages open in relatively small windows,
because QScrollArea inside reports small size hint

Test Plan:
patched 5.48.0 with this, tested networkmanager and few other kcms,
they now seem to open in full size (except for kscreen which has custom
sizehint,
it probably needs size hint for the QML area specifically, not the whole
window;
and except for opengl that has it's own scrollable area which needs a size hint
too)

Reviewers: #frameworks, ngraham

Reviewed By: ngraham

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D14692

M +1 -1 src/kcmultidialog.cpp
M +22 -0 src/kcmultidialog.h

https://commits.kde.org/kcmutils/23ba2b37ef825f0efccc169455f45b0dcdac97cf

[b***@kde.org]

https://bugs.kde.org/show_bug.cgi?id=389585

***@yandex.com changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@protonmail.ch

--- Comment #23 from ***@yandex.com ---
*** Bug 397437 has been marked as a duplicate of this bug. ***

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=389585

Christoph Feck <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@phoenitydawn.
| |de

--- Comment #24 from Christoph Feck <***@kde.org> ---
*** Bug 396748 has been marked as a duplicate of this bug. ***

[Øystein Steffensen-Alværvik]

https://bugs.kde.org/show_bug.cgi?id=389585

--- Comment #25 from Øystein Steffensen-Alværvik <***@posteo.net> ---
Good work.

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389585

--- Comment #27 from Nate Graham <***@kde.org> ---
Yes, the patch resolves the issue with HiDPI as well (at least for me).

[Andrew Crouthamel]

https://bugs.kde.org/show_bug.cgi?id=389585

--- Comment #28 from Andrew Crouthamel <***@kdemail.net> ---
(In reply to Nate Graham from comment #27)

Post by Nate Graham
Yes, the patch resolves the issue with HiDPI as well (at least for me).

Awesome! This was one of those minor nuisances that I wasn't sure where to file
it. I'll have to test in the coming weeks.

[Andrew Crouthamel]

https://bugs.kde.org/show_bug.cgi?id=389585

Andrew Crouthamel <***@kdemail.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@kdemail.n
| |et

--- Comment #26 from Andrew Crouthamel <***@kdemail.net> ---
I've noticed this issue when using scaling on a hidpi system. Does this patch
solve when scaling?

[Dr. Chapatin]

https://bugs.kde.org/show_bug.cgi?id=389585

Dr. Chapatin <***@gmx.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@uwaterloo.ca

--- Comment #29 from Dr. Chapatin <***@gmx.com> ---
*** Bug 397361 has been marked as a duplicate of this bug. ***

[Dr. Chapatin]

https://bugs.kde.org/show_bug.cgi?id=389585

--- Comment #30 from Dr. Chapatin <***@gmx.com> ---
is the fix available on neon dev unstable?
bug persists in such distro.

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389585

--- Comment #31 from Nate Graham <***@kde.org> ---
(In reply to Dr. Chapatin from comment #30)

Post by Dr. Chapatin
is the fix available on neon dev unstable?
bug persists in such distro.

1x scale or a different scale?

[Dr. Chapatin]

https://bugs.kde.org/show_bug.cgi?id=389585

--- Comment #32 from Dr. Chapatin <***@gmx.com> ---
Tested both 1x and 1.2x scale:

"per-activity power management" window opened via krunner is too small (bug
379858)

power saving kcm has horizontal scroll bar

network manager kcm: vertical scroll bar when scale is 1x,
therefore the buttons on botton are hidden (bug 393891, bug 395602, bug
392314). When display scale is 1.2x, both horizontal and vertical scroll bars
are active.

"desktop effects" opened via krunner is too small (bug 396076)

touchpad kcm has horizontal scroll bar when scale is 1.2x (bug 397361).

[Andrew Crouthamel]

https://bugs.kde.org/show_bug.cgi?id=389585

--- Comment #33 from Andrew Crouthamel <***@kdemail.net> ---
I also still have this issue.

I just tested on a Dell XPS 13 (4k), with latest Neon Unstable (Frameworks
5.50) booted natively (no VM), and I have vertical scrollbars in most
standalone KCM apps. Displays is the worst for me.

The issue seems to get worse as scaling is increased. I usually run at 2x.

The horizontal scrollbars seem to go away for me though, so that's a positive
note.

I think we should reopen this...

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389585

--- Comment #34 from Nate Graham <***@kde.org> ---
Created attachment 114800
--> https://bugs.kde.org/attachment.cgi?id=114800&action=edit
Network KCM looks fine to me now

I'm attaching an image of what `kcmshell5 kcm_networkmanagement` shows at 1x
scaling for me now. Looks fine to me. Andrew and bugseforuns, can you confirm
that this is what it looks like for you at 1x? If it looks bad at > 1x, that's
a separate bug, or an issue with the patch that we didn't catch (oops), in
which case we should track that with a new bug.

I do notice that some other KCMs such as Applications, Desktop Effects, and
Displays are a bit too small at 1x, but they're not absolutely tiny the way
they used to be. I suspect what's happening here is that we fixed the general
bug about kcmshell not respecting KCMs' sizeHints that was preventing KCMs from
being able to be sized correctly within kcmshell at all, but now we need to
adjust some individual KCMs so that they pass an appropriate sizeHint to the
shell. Probably we should un-dupe the bugs that were tracking the individual
KCMs that still need adjustment so we can fix their sizeHints.

[Valeriy Malov]

https://bugs.kde.org/show_bug.cgi?id=389585

--- Comment #35 from Valeriy Malov <***@gmail.com> ---
Seems like a lot of KCMs that are still bugged are QML ones that rely on rely
on KQuickAddons::ConfigModule

kcm_fileindexermonitor
kcm_fonts
kcm_launchfeedback
kcm_translations
kcm_workspace

Some QML KCMs work fine though, like Networks or Mouse. Both have some sort of
top level UI or QWidget, e.g. mouse KCM propagates sizeHint from QML properties
into a QWidget

KQuickAddons::ConfigModule on the other hand is just a QObject with no concept
of size hint. It seems like something should be done with ConfigModule, but
just turning it into a QWidget with sizeHint makes no difference since no one
ever asks it it's sizeHint anyway. I'm not really familiar with QML to fix this
right away :/ This probably should be split out into a separate bug?

[Dr. Chapatin]

https://bugs.kde.org/show_bug.cgi?id=389585

--- Comment #36 from Dr. Chapatin <***@gmx.com> ---
Created attachment 114815
--> https://bugs.kde.org/attachment.cgi?id=114815&action=edit
Network kcm on neon dev unstable. Hidden buttons on bottom.

[Andrew Crouthamel]

https://bugs.kde.org/show_bug.cgi?id=389585

--- Comment #37 from Andrew Crouthamel <***@kdemail.net> ---
(In reply to Nate Graham from comment #34)

Created attachment 114800 [details]
Network KCM looks fine to me now
I'm attaching an image of what `kcmshell5 kcm_networkmanagement` shows at 1x
scaling for me now. Looks fine to me. Andrew and bugseforuns, can you
confirm that this is what it looks like for you at 1x? If it looks bad at >
1x, that's a separate bug, or an issue with the patch that we didn't catch
(oops), in which case we should track that with a new bug.

I confirm it looks OK at 1x. 2x I get scrollbars.

[Valeriy Malov]

https://bugs.kde.org/show_bug.cgi?id=389585

--- Comment #38 from Valeriy Malov <***@gmail.com> ---
(In reply to Dr. Chapatin from comment #36)

Created attachment 114815 [details]
Network kcm on neon dev unstable. Hidden buttons on bottom.

Ok, when dialog is adjusted based on the size hint, its size is limited by 2/3
of the desktop size (hardcoded in QWidgetPrivate::adjustedSize:
https://bugreports.qt.io/browse/QTBUG-3459). That's probably the cause of issue
here. I guess it can be worked around by a custom adjustSize() function.

No idea if that's related to hi-dpi issues, can't test that.

[b***@kde.org]

https://bugs.kde.org/show_bug.cgi?id=389585

--- Comment #39 from ***@yandex.com ---
(In reply to Dr. Chapatin from comment #36)

Created attachment 114815 [details]
Network kcm on neon dev unstable. Hidden buttons on bottom.

Confirm this.

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389585

--- Comment #40 from Nate Graham <***@kde.org> ---
(In reply to Dr. Chapatin from comment #36)

Created attachment 114815 [details]
Network kcm on neon dev unstable. Hidden buttons on bottom.

Looks like this particular issue is caused by
https://bugreports.qt.io/browse/QTBUG-3459, as Valeriy indicates.

I'd prefer to go the route of fixing it in Qt rather than working around it
locally (though that's an option too, if worse comes to worst).


So it seems that we have three angles of attack:

1. Fix individual KCMs that don't give us proper SizeHints, now that kcmshell
*pays attention to sizeHints. Bugseforuns, since you're carefully tracking the
issues here, would you like to un-dupe the bugs for individual KCMs that still
need adjustment and add appropriate comments?

2. Fix or work around https://bugreports.qt.io/browse/QTBUG-3459 so that KCMs
sizeHints are actually properly respected on short screens. Valeriy, would you
be interested in tackling that?

3. Fix the issue with the fix for this bug not working for HiDPI. Andrew, since
you have a HiDPI screen, would you like to investigate this part?

[Andrew Crouthamel]

https://bugs.kde.org/show_bug.cgi?id=389585

--- Comment #41 from Andrew Crouthamel <***@kdemail.net> ---
I'd love to help, but this is honestly outside of my capabilities at the
moment. I'd be glad to work with someone and test though.

[Valeriy Malov]

https://bugs.kde.org/show_bug.cgi?id=389585

--- Comment #42 from Valeriy Malov <***@gmail.com> ---
Workaround for QTBUG-3459

https://phabricator.kde.org/D15406

[Valeriy Malov]

https://bugs.kde.org/show_bug.cgi?id=389585

--- Comment #43 from Valeriy Malov <***@gmail.com> ---
Git commit cc4ecfdcd48a52a67f60eb69ed69e91ca42ee405 by Valeriy Malov.
Committed on 12/09/2018 at 02:20.
Pushed by valeriymalov into branch 'master'.

Manually resize KCMUtilDialog to sizeHint()

Summary:
Workaround for https://bugreports.qt.io/browse/QTBUG-3459

Currently adjustSize() is limited to 2/3 of the screen size for windows
This adds unnecessary scrollbars on dialogs that would otherwise fit the
screen
Manually resize the window after adjustSize() happens to avoid this
limitation

Test Plan:
Tested on a 1366x768 laptop, with this patch networkmanagement window opens
in full screen height (respecting the panel)

Reviewers: #frameworks, ngraham

Reviewed By: ngraham

Subscribers: davidedmundson, acrouthamel, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D15406

M +13 -2 src/kcmultidialog.cpp

https://commits.kde.org/kcmutils/cc4ecfdcd48a52a67f60eb69ed69e91ca42ee405

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389585

--- Comment #44 from Nate Graham <***@kde.org> ---
Awesome. Now we're down to two issues:
- Fix High DPI
- Fix individual KCMs that provide incorrect sizeHints. For this we should
probably un-dupe any bugs for individual KCMs that still have a problem at 1x
with current git master.

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389585

Nate Graham <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Version Fixed In| |5.51
See Also| |https://bugs.kde.org/show_b
| |ug.cgi?id=398820,
| |https://bugs.kde.org/show_b
| |ug.cgi?id=398805,
| |https://bugs.kde.org/show_b
| |ug.cgi?id=398799,
| |https://bugs.kde.org/show_b
| |ug.cgi?id=398798,
| |https://bugs.kde.org/show_b
| |ug.cgi?id=398793,
| |https://bugs.kde.org/show_b
| |ug.cgi?id=398797

--- Comment #45 from Nate Graham <***@kde.org> ---
New bug for QML KCMs not properly passing on their sizeHints: Bug 398820

New bugs for individual other KCMs with inappropriate sizeHint values:
- Formats: Bug 398805
- Applications: Bug 398799
- Bluetooth: Bug 398798
- Per-activity power settings: Bug 398793
- Icons: Bug 398797

Thanks for filing these bugs, Dr. Chapatin.

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389585

Nate Graham <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.kde.org/show_b
| |ug.cgi?id=396076

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389585

--- Comment #46 from Nate Graham <***@kde.org> ---
Desktop effects: Bug 396076

[Patrick Silva]

https://bugs.kde.org/show_bug.cgi?id=389585

Patrick Silva <***@gmx.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.kde.org/show_b
| |ug.cgi?id=400355

[b***@kde.org]

https://bugs.kde.org/show_bug.cgi?id=389585

--- Comment #47 from ***@yandex.com ---
Maybe relate: https://bugs.kde.org/show_bug.cgi?id=400355

[Patrick Silva]

https://bugs.kde.org/show_bug.cgi?id=389585

Patrick Silva <***@gmx.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@web.de

--- Comment #48 from Patrick Silva <***@gmx.com> ---
*** Bug 401163 has been marked as a duplicate of this bug. ***

[Patrick Silva]

https://bugs.kde.org/show_bug.cgi?id=389585

Patrick Silva <***@gmx.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@coubronne.net

--- Comment #49 from Patrick Silva <***@gmx.com> ---
*** Bug 401718 has been marked as a duplicate of this bug. ***